stevedlawrence commented on code in PR #40:
URL: https://github.com/apache/daffodil-sbt/pull/40#discussion_r1670673166
##########
src/main/scala/org/apache/daffodil/DaffodilSaver.scala:
##########
@@ -40,8 +40,16 @@ object DaffodilSaver {
*/
def main(args: Array[String]): Unit = {
- if (args.length != 4) System.err.println(s"[error] four arguments are
required")
+ if (args.length != 4) {
+ System.err.println(s"four arguments are required")
Review Comment:
Users should never call this directly. DaffodilSaver.scala should always be
forked by DaffodilPlugin.scala. So the only way for the length to not be
correct is if we update DaffodilPlugin.scala to fork the saver with a different
number of arguments but don't update DaffodilSaver.scala to match. Really this
wants to be something like an assert.invariant, but I don't think SBT has a
good way to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
