mbeckerle commented on code in PR #1289: URL: https://github.com/apache/daffodil/pull/1289#discussion_r1750348304
########## daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesExpressions.scala: ########## @@ -197,6 +202,7 @@ case class SetVariable(stmt: DFDLSetVariable, override val term: Term) override lazy val exprText = stmt.value override lazy val exprNamespaces = stmt.xml.scope + override lazy val exprTargetNamespace = stmt.annotatedSC.targetNamespace Review Comment: I suggest merging this as is. There are a variety of other namespace-related things I'd like to consider before designing the complete solution. Minimization of namespace bindings is one of them, for example, which involves assembling more than one such context and potentially creating unique namespace prefix bindings to resolve ambiguity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
