olabusayoT commented on code in PR #1305:
URL: https://github.com/apache/daffodil/pull/1305#discussion_r1771656426
##########
daffodil-test/src/test/resources/org/apache/daffodil/extensions/repType/repType.tdml:
##########
@@ -863,6 +878,11 @@
<tdml:error>ex:field</tdml:error>
<tdml:error>facet length (1)</tdml:error>
</tdml:validationErrors>
+ <tdml:warnings>
+ <tdml:warning>FacetsContradict</tdml:warning>
+ <tdml:warning>'t' contradicts with value of 'minLength'
facet</tdml:warning>
+ <tdml:warning>'three' contradicts with value of 'maxLength'
facet</tdml:warning>
Review Comment:
I'll update to using the keywords, but I believe this is a xerces error that
is then thrown as a warning. So we can't update the actual wording of the
warning. I think the issue is that the enums are outside of the bounds of
length facets, so it's saying the existing facets contradict each other. As to
whether it should be a validationError, I think it makes sense as a warning
rather than a validation error, because if you do have contradicting facets
that most likely indicates a mistake on the user's side and we will always want
to inform them of this. If we made it a validation error, one would need to
turn on validation before the possible user error gets caught, which I don't
think is right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
