stevedlawrence opened a new pull request, #1314: URL: https://github.com/apache/daffodil/pull/1314
Commit 2590f54ce9 change it so that if no default namespace is defined then an unprefixed QName reference is resolved using the targetNamespace as its namespace. However, this logic was not correct. Instead, we need different logic depending on if the schema containing such a reference is included vs imported. In the former case, we should use the targetNamespace of the including schema. In the latter, we should just use no-namespace. This modifies the logic to add a new 'noPrefixNamespace' member which keeps track of what namespace to use when resolving a unprefixed QName reference using include/import information. This member replaces previous changes of targetNamespace. This found a number of tests where references to defined formats were not actually correct but happened to work due to previously flawed logic. This corrects these tests, and adds additional tests to make sure include/import logic works as expected. Deprecation/Compatibility: A bug was fixed so Daffodil now correctly handles resolving unprefixed QName references. However, this means that some unprefixed references that relied on the previous incorrect behavior may not resolve anymore. Although there are a number of ways to fix this, defining a namespace prefix and adding that prefix to broken reference should work in all cases. DAFFODIL-2961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
