stevedlawrence commented on code in PR #1334:
URL: https://github.com/apache/daffodil/pull/1334#discussion_r1799381701
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/ElementBaseGrammarMixin.scala:
##########
@@ -194,8 +194,9 @@ trait ElementBaseGrammarMixin
)
schemaDefinitionWhen(
detachedElementDecl.statements.nonEmpty,
- "%s is specified as a dfdl:prefixLengthType, but specifies one or more
statement annotations",
- prefixLengthType
+ "%s is specified as a dfdl:prefixLengthType, but specifies one or more
statement annotations (%s)",
+ prefixLengthType,
+ detachedElementDecl.statementsAsStrings.mkString(", ")
Review Comment:
I believe `toString` on any DFDLAnnotation already does this conversion to a
pretty string, so I don't think we need `statementsAsString`. I *think* you can
just do
```scala
detachedElementDecl.statemtents.mkString(", ")
```
And it'll do the right thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
