jadams-tresys commented on code in PR #1341:
URL: https://github.com/apache/daffodil/pull/1341#discussion_r1803000438
##########
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/unparsers/runtime1/SpecifiedLengthUnparsers.scala:
##########
@@ -87,122 +86,31 @@ final class SpecifiedLengthExplicitImplicitUnparser(
// but we don't know if the length units characters or bits/bytes.
lengthUnits match {
case LengthUnits.Bits | LengthUnits.Bytes =>
- unparseVarWidthCharactersInBits(state)
- case LengthUnits.Characters =>
- unparseVarWidthCharactersInCharacters(state)
+ eUnparser.unparse1(state)
+ case LengthUnits.Characters => {
+ //
+ // variable-width encodings and lengthUnits characters, and
lengthKind explicit
+ // is not supported (currently) for complex types
+ //
+ state.schemaDefinitionUnless(
Review Comment:
Just trying to remember, is it still an SDE if it is something that just
isn't supported yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
