olabusayoT commented on code in PR #1366:
URL: https://github.com/apache/daffodil/pull/1366#discussion_r1844059124
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/SchemaSet.scala:
##########
@@ -563,6 +606,10 @@ final class SchemaSet private (
else {
val hasErrors = super.isError
if (!hasErrors) {
+ // after compilation is done, we want to walk through all our refs and
+ // if a property is in the cache of the referencer, put it into the
+ // cache of the referenced element
+ propagateReferenceeAndTypeUsedProperties
Review Comment:
So I considered doing at the time of property lookup, but we do that in
daffodil-lib which doesn't have access to the daffodil-lib classes like
ElementRef that'd make it possible to find the element refs/simple types.
For the 2nd suggestion, we run into the same issues where 2 element refs
share the element they are referencing but only the first element ref 's
propCache show it as using the properties, not the referenced element and not
the 2nd element ref. Which is why we opted for propagation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
