stevedlawrence commented on code in PR #1380:
URL: https://github.com/apache/daffodil/pull/1380#discussion_r1869402720
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/ComplexTypes.scala:
##########
@@ -54,6 +54,16 @@ sealed abstract class ComplexTypeBase(xmlArg: Node,
parentArg: SchemaComponent)
s
}
+ modelGroup match {
Review Comment:
Everything else in this class is lazy or a def except for this. I'm not sure
if there's a reason for that, but this being non-lazy will force evaluation of
those things, which I'm not sure was intended. Maybe move this check into the
`lazy val Seq(modelGroup)` block, something like `s(0) match { ...`? So it it
will be lazily checked along with the other SDE in this class?
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/ComplexTypes.scala:
##########
@@ -54,6 +54,16 @@ sealed abstract class ComplexTypeBase(xmlArg: Node,
parentArg: SchemaComponent)
s
}
+ modelGroup match {
+ case s: SequenceGroupTermBase =>
+ schemaDefinitionWhen(
Review Comment:
Does it make sense to do `s.schemaDefinitionWhen` so that the context of the
SDE is the xs:sequence line that contains hiddenGroupRef instead of the
xs:complexType line? I guess in reality they will always be right next to each
other, but since the problem is really the xs:sequence that maybe gives a
slightly more accurate diagnostic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
