mbeckerle commented on code in PR #83:
URL: https://github.com/apache/daffodil-sbt/pull/83#discussion_r1901795200
##########
src/main/scala/org/apache/daffodil/DaffodilPlugin.scala:
##########
@@ -389,6 +391,16 @@ object DaffodilPlugin extends AutoPlugin {
dbi.config.map { _.toString }.getOrElse("")
)
+ // SBT has the concept of an "export stream"--this is a stream
that an SBT task can
Review Comment:
Ok, so this is a very cool thing.
Can you add a line to this comment about OS platform portability? Is this
command "current platform" compatible, or ??
E.g., The java classpath becomes an argument to this java command? That
requires OS-specific syntax for the separator (: vs. ;) Or is classpath still
handled separately somehow?
This overall feature will need documenting in the README.md for the plugin.
Though perhaps we should develop the whole debug idiom and explain that rather
than explain just how this export operation works. E.g., suppose it turns out
users need to add things like "-Xmx4g -Xss4m" or such.
There are sort of two use cases for this feature.
1. I am a regular DFDL user and just want to make shell scripts to build and
run my parse/unparse testing assembling the classpath and such for me so that
all my dependent schemas, charsets, layers, and UDFs are found.
3. I am a daffodil developer and want to debug daffodil in the context of a
DFDL schema project.
The former needs to be documented in the README.md.
The latter could be documented in a separate place, such as on our Wiki.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
