stevedlawrence commented on code in PR #987:
URL: https://github.com/apache/daffodil/pull/987#discussion_r1904304825
##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/parsers/Parser.scala:
##########
@@ -241,8 +244,14 @@ final class SeqCompParser(context: RuntimeData, val
childParsers: Vector[Parser]
while (i < numChildParsers) {
val parser = childParsers(i)
parser.parse1(pstate)
- if (pstate.processorStatus ne Success)
+ if (pstate.processorStatus ne Success) {
+ if (testAssert.nonEmpty) {
+ testAssert.foreach { ap =>
Review Comment:
Just had another thought about this, this will evaluate all assertions even
if one fails. Is that the correct behavior, or should it stop after the first
assertion failure? Seems like if one assertion fails it shouldn't continue to
evaluate other assertions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
