mbeckerle commented on PR #1338: URL: https://github.com/apache/daffodil/pull/1338#issuecomment-2635074861
ChatGPT thinks that yes there are issues with CodeCov and Scala code: https://chatgpt.com/share/67a28042-0944-800f-b2e5-95c1856c91d6 On Tue, Feb 4, 2025 at 1:55 PM olabusayoT ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/ElementBaseGrammarMixin.scala > <https://github.com/apache/daffodil/pull/1338#discussion_r1941736405>: > > > + } > + case LengthKind.Implicit if isSimpleType && primType == PrimType.String => > + new SpecifiedLengthImplicitCharacters(this, body, this.maxLength.longValue) > + > + case LengthKind.Implicit if isSimpleType && primType == PrimType.HexBinary => > + new SpecifiedLengthImplicit(this, body, this.maxLength.longValue * bitsMultiplier) > + case LengthKind.Implicit > + if isSimpleType && impliedRepresentation == Representation.Binary => > + new SpecifiedLengthImplicit(this, body, implicitBinaryLengthInBits) > + case LengthKind.Implicit if isComplexType => > + body // for complex types, implicit means "roll up from the bottom" > + case LengthKind.EndOfParent if isComplexType => > + notYetImplemented("lengthKind='endOfParent' for complex type") > + case LengthKind.EndOfParent => > + notYetImplemented("lengthKind='endOfParent' for simple type") > + case _ => { > > Maybe there's a bug with code coverage, hexBinary_bits_be_msbf definitely > hits the default case > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/daffodil/pull/1338#discussion_r1941736405>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AALUDAZJDC6SSICL3X2HUDD2OEEKLAVCNFSM6AAAAABQADPAVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJTG43TOMBUHA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
