jadams-tresys commented on code in PR #1426:
URL: https://github.com/apache/daffodil/pull/1426#discussion_r1949225292
##########
daffodil-lib/src/test/scala/org/apache/daffodil/lib/util/TestMaybeInlineForeach.scala:
##########
@@ -99,9 +99,9 @@ final class TestMaybeInlineForeach {
*/
// @Test
def testForeachVersusIfDefined(): Unit = {
- val foreachNanos: Double = time(testForeach)
- val ifDefinedNanos: Double = time(testIfDefined)
- val ifNullNanos: Double = time(testIfNull)
+ val foreachNanos: Double = time(testForeach()).toDouble
+ val ifDefinedNanos: Double = time(testIfDefined()).toDouble
+ val ifNullNanos: Double = time(testIfNull()).toDouble
Review Comment:
I know that this is what was decided for Scala 2.13/3, but the inconsistency
of the parens here bugs me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
