jadams-tresys commented on code in PR #1427: URL: https://github.com/apache/daffodil/pull/1427#discussion_r1951590021
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/infoset/InfosetImpl.scala: ########## @@ -1221,20 +1217,22 @@ final class DIArray( def namedQName = erd.namedQName - protected final var _contents = new ArrayBuffer[DIElement](initialSize) + protected final val _contents = new ArrayBuffer1[DIElement](initialSize) - override def children: LazyList[DINode] = - _contents.view.map(_.asInstanceOf[DINode]).to(LazyList) + override def indexOf(item: DINode): Int = _contents.indexOf(item.asInstanceOf[DIElement]) Review Comment: I don't really see a problem with making small fixes like this that aren't changing functionality as part of the changes for 2.13/3. It could be easy to forget to come back to fix these sorts of things later. That being said, doing a full audit of all our asInstanctOf calls might not be a bad idea as there are probably other areas where the same changes could be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
