stevedlawrence commented on code in PR #1432:
URL: https://github.com/apache/daffodil/pull/1432#discussion_r1953211529


##########
.github/actions/asf-release-candidate/action.yml:
##########
@@ -0,0 +1,99 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   One of the reasons I've marked this as a draft is because I don't think this 
action wants to live in the daffodil repo. When publishing an action you either 
need to commit the `node_modules` directory (which is ~130MB), or essentially 
statically 'compile' the the main.js/post.js files and commit those. I'm not 
sure that would be appropriate in the Daffodil repo. Feels like we either need 
a separate daffodil-infrastructure repo, or maybe use daffodil-extra or 
something. The build-release container might also want to live there since it 
also isn't specifically about daffodil since it also works for vs code and sbt 
extensions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to