stevedlawrence commented on code in PR #1440:
URL: https://github.com/apache/daffodil/pull/1440#discussion_r1965943273


##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/SequenceCombinator.scala:
##########
@@ -117,7 +117,11 @@ class OrderedSequence(sq: SequenceTermBase, 
sequenceChildrenArg: Seq[SequenceChi
             sepMtaAlignmentMaybe,
             sepMtaUnparserMaybe,
             sepUnparser,
-            childUnparsers
+            childUnparsers.map(
+              _.asInstanceOf[
+                SequenceChildUnparser with 
org.apache.daffodil.unparsers.runtime1.Separated

Review Comment:
   One option would be to add an import right before these lines, e.g.
   
   ```scala
   import org.apache.daffodil.unparsers.runtime1.Separated
   childUnparsers.map(_.asInstanceOf[SequenceChildUnparser with Separated)
   ```
   
   I think that works?
   
   Another option would to be rename on import at the top, e.g.
   ```scala
   import org.apache.daffodil.runtime1.processors.parsers.{ Separated => 
SeparatedParser }
   import org.apache.daffodil.unparsers.runtime1.{ Separated => 
SeparatedUnparser }
   ```
   And the use `with SeparatedParser` or `with SeparatedUnparser`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to