scholarsmate commented on code in PR #1183:
URL: https://github.com/apache/daffodil-vscode/pull/1183#discussion_r1971617026
##########
src/dataEditor/config/Extract.ts:
##########
@@ -41,12 +41,24 @@ function extractDataEditorConfigFromQuery(
export function extractConfigurationVariables(): IConfig {
const configObjArray = queryConfigurationsArray()
+ const workspaceConfig = workspace.getConfiguration()
+ const defaultConfig: Config = {
+ ...Config.Default, // Default configs
+ port: workspaceConfig.dataEditor?.port || Config.Default.port, // Get
dataEdtior port from settings.json if it exists
+
+ // To PR Reviewers, do we need the following below or no? Otherwise, the
bottom 2 attributes get ignored from settings.json VSCode users folder.
+ // logLevel:
+ // workspaceConfig.dataEditor?.logging?.level || Config.Default.logLevel,
+ // logFile:
+ // workspaceConfig.dataEditor?.logging?.file || Config.Default.logFile,
Review Comment:
Uncomment these as we want those to be settable in settings.json and
respected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
