olabusayoT commented on code in PR #1451:
URL: https://github.com/apache/daffodil/pull/1451#discussion_r1983981691
##########
daffodil-lib/src/main/scala/org/apache/daffodil/lib/exceptions/SchemaFileLocatable.scala:
##########
@@ -125,7 +125,12 @@ class XercesSchemaFileLocation(
) extends SchemaFileLocation(
(if (xercesError.getLineNumber > 0)
Some(xercesError.getLineNumber.toString) else None),
(if (xercesError.getColumnNumber > 0)
Some(xercesError.getColumnNumber.toString) else None),
- schemaFileLocation.diagnosticFile,
+ (if (
+ xercesError.getSystemId != null &&
+ // only set to systemId if it's different from the diagnosticFile path
+
!xercesError.getSystemId.endsWith(schemaFileLocation.diagnosticFile.getPath)
+ ) new File(xercesError.getSystemId)
+ else schemaFileLocation.diagnosticFile),
Review Comment:
Oh yea, this particular error is because
org.apache.xml.resolver.readers.OASISXMLCatalogReader.class needs to be
regsistered for reflection for our catalog to work. Without t it's not able to
resolve the imports. I commented out that class in our reflection registration
just to display that pearticluar schema context in the SDE. As such I don't
think it represents an error in Daffodil. I haven't messed with validation in
Quarkus, an oversight on my part...I'll test it now to see if we get an error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
