mbeckerle commented on code in PR #1453:
URL: https://github.com/apache/daffodil/pull/1453#discussion_r1992000171


##########
daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/processors/unparsers/UState.scala:
##########
@@ -423,6 +429,7 @@ final class UStateForSuspension(
   areDebugging: Boolean
 ) extends UState(vbox, mainUState.diagnostics, mainUState.dataProc, tunable, 
areDebugging) {
 
+  setDataOutputStream(dataOutputStream)

Review Comment:
   I believe this is correct - once you have created a UStateForSuspension, 
lots of things are frozen there. 
   
   That said, the interplay and way output streams do this gradual 
double-buffering and collapsing of the buffers is quite tricky. It's the most 
complex part of the Daffodil runtime, so .... do I really know that there's no 
exception to this rule? No. We should try it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to