stevedlawrence commented on code in PR #1184: URL: https://github.com/apache/daffodil-vscode/pull/1184#discussion_r2018729446
########## VERSION: ########## @@ -0,0 +1 @@ +1.4.1-SNAPSHOT Review Comment: The action was intended to be run immediately after the checkout action and before yarn/npm/sbt/etc commands are run that could generate that file. I *guess* it might work to run something to generate the VERSION file in between checkout and asf-release-candidate actions, but it feels safer to run from a clean slate. I'm open to other suggestions for the action to figure out the version, but I would like to avoid parsing build configs. That worked in the past because we only have three projects, but I really want this action to be general and simple enough that it could be used by other ASF projects so that maybe someday the maintenance could be shared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
