scholarsmate commented on code in PR #1223:
URL: https://github.com/apache/daffodil-vscode/pull/1223#discussion_r2034037890


##########
src/language/providers/intellisense/elementItems.ts:
##########
@@ -122,7 +122,7 @@ export const elementCompletion = (definedVariables, 
nsPrefix) => {
       },
       {
         item: 'dfdl:defineEscapeScheme',
-        snippetString: '<' + nsPrefix + 'defineEscapeScheme name=$1 
>\n\t$0,/dfdl:defineEscapeScheme>',
+        snippetString: '<dfdl:defineEscapeScheme name=$1 
>\n\t$0</dfdl:defineEscapeScheme>',

Review Comment:
   Are you sure we want to hard code the dfdl namespace?  @rthomas320, are you 
good with this change? The `<` instead of the `,` appears to be the real fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to