stevedlawrence commented on PR #1501: URL: https://github.com/apache/daffodil/pull/1501#issuecomment-2981478157
> Consider whether some of your description of this bug about how the woodstox API is supposed to be used should be added as comments to this code. I think what we are doing now is really just standard practice for XMLStreamReaders. It feels like any mention in the code of the allocator being the wrong thing to do is just going to add confusion, since it really shouldn't be considered in the context of an XMLStreamReader--the getLocation function is clearly what should be used to get the location. My best guess at how we ended up using an allocator in the first place is that InfosetInputters used to be implemented very differently (before we even had the concept of an InfosetInputter) with different libraries, and those libraries really did need the allocator to get location. But over the years things have changed significantly and using the normal XMLStreamReader.getLocation does the right thing. That's just a guess though, it's kindof a pain to track to full history of the implementation since things have moved around and changed so much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
