olabusayoT commented on code in PR #1479: URL: https://github.com/apache/daffodil/pull/1479#discussion_r2198629322
########## daffodil-core/src/main/scala/org/apache/daffodil/runtime1/iapi/DFDLParserUnparser.scala: ########## @@ -113,113 +106,54 @@ object DFDL { schemaSource: DaffodilSchemaSource, optRootNodeName: Option[String] = None, optRootNodeNamespace: Option[String] = None - ): ProcessorFactory - - def reload(savedParser: File): DataProcessor + ): api.ProcessorFactory } /** * The point of [[ProcessorFactory]] is to allow compilation of the path expression * and/or generation of source code to process data matching the compiled schema */ - trait ProcessorFactory extends WithDiagnostics { + trait ProcessorFactory extends WithDiagnostics with api.ProcessorFactory { /** - * Returns a [[DataProcessor]] to process data matching a compiled XPath expression - * @param xpath XPath expression in DFDL schema that data should match (you can use only "/" at this time) - */ - def onPath(xpath: String): DataProcessor - - /** - * Returns a [[CodeGenerator]] to generate code from a DFDL schema to parse or unparse data + * Returns a [[org.apache.daffodil.api.CodeGenerator]] to generate code from a DFDL schema to parse or unparse data * @param language source language for generated code (you can use only "c" at this time) */ - def forLanguage(language: String): CodeGenerator + def forLanguage(language: String): api.CodeGenerator Review Comment: Created an @Experimental annotation in the api package, and used that on the new api function forLanguage -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org