JeremyYao commented on code in PR #1329:
URL: https://github.com/apache/daffodil-vscode/pull/1329#discussion_r2209877648
##########
src/language/providers/attributeCompletion.ts:
##########
@@ -83,6 +84,11 @@ function getPotentialAttributeText(
let upperLineBound: number = position.line
// Determining the lowerbound strategy: Traverse backwards line-by-line
until we encounter an opening character (<)
+
+ //handle edge case if there's an element closing on the same line or if
there is a closing tag after the cursor on the same line
+ if (lowerLineBound > 0) {
Review Comment:
Are you able to implement the off-by-one code changes for
prunedDuplicateAttributes?
##########
src/language/providers/attributeCompletion.ts:
##########
@@ -83,6 +84,11 @@ function getPotentialAttributeText(
let upperLineBound: number = position.line
// Determining the lowerbound strategy: Traverse backwards line-by-line
until we encounter an opening character (<)
+
+ //handle edge case if there's an element closing on the same line or if
there is a closing tag after the cursor on the same line
+ if (lowerLineBound > 0) {
Review Comment:
Refer to the screenshots
<img width="2756" height="411" alt="image"
src="https://github.com/user-attachments/assets/05c802c2-40c3-4dd0-bfd2-914b70edae8d";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
