olabusayoT commented on code in PR #1479:
URL: https://github.com/apache/daffodil/pull/1479#discussion_r2211372779
##########
daffodil-codegen-c/src/main/scala/org/apache/daffodil/codegen/c/DaffodilCCodeGenerator.scala:
##########
@@ -78,10 +79,10 @@ import
org.apache.daffodil.runtime1.dsom.SchemaDefinitionWarning
*
* @param root Passes DFDL schema from which to generate code
*/
-class DaffodilCCodeGenerator(root: Root) extends DFDL.CodeGenerator {
+class DaffodilCCodeGenerator(root: Root) extends api.CodeGenerator {
// Note this class is not thread-safe due to mutable state needed to
// implement WithDiagnostics trait
- private var diagnostics: Seq[Diagnostic] = Nil
+ private var diagnostics: java.util.List[api.Diagnostic] =
util.Collections.emptyList()
Review Comment:
Agreed! updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
