stevedlawrence commented on code in PR #1509:
URL: https://github.com/apache/daffodil/pull/1509#discussion_r2240566138


##########
build.sbt:
##########
@@ -58,7 +58,7 @@ lazy val daffodil = project
 
 lazy val macroLib = Project("daffodil-macro-lib", file("daffodil-macro-lib"))
   .settings(commonSettings, nopublish)
-  .settings(libraryDependencies += "org.scala-lang" % "scala-reflect" % 
scalaVersion.value)
+  .settings(libraryDependencies += "org.scala-lang" % "scala-reflect" % 
"2.13.16")

Review Comment:
   So should this be something like this?
   
   ```scala
   .settings(
      if (scalaVersion == 3.x.x) Seq()
      else Seq(libraryDependencies += "org.scala-lang" % "scala-reflect" % 
"2.13.16")
   )
   ```
   
   So that when using Scala 3.x we don't add a scala-reflect dependency.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to