shanedell commented on code in PR #1336:
URL: https://github.com/apache/daffodil-vscode/pull/1336#discussion_r2245754117
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -410,13 +425,12 @@ export function activateDaffodilDebug(
.map((obj) => obj.name) as string[]
// dropdown
- return await vscode.window
- .showQuickPick(test_case_names, {
- placeHolder: 'Test Case Name',
- })
- .then((value) => {
- return value // return selected dropdown value
- })
+ // Await showQuickPick directly and return the result
+ const selection = await vscode.window.showQuickPick(test_case_names, {
+ placeHolder: 'Test Case Name',
+ })
+
+ return selection
Review Comment:
@michael-hoke I'm not sure what you mean by not being okay with the update
to the if statement. The only change happening is making sure the type of the
attributes of the TDMLConfig class are `string` and not `String`. This makes it
so you don't have to do `typeof tdmlConfig.path === 'string'` or `typeof
tdmlConfig.action === 'string'` as both `path` and `action` should only be
either a `string` or `undefined`. So, we should not have to strictly check that
type for either `path` and `action`, currently you have to do that since its
`String | undefined`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
