michael-hoke commented on code in PR #1336:
URL: https://github.com/apache/daffodil-vscode/pull/1336#discussion_r2254978271
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -168,35 +168,52 @@ function createDebugRunFileConfigs(
tdmlConfig.action = tdmlAction
if (tdmlAction === 'execute') {
- tdmlConfig.name = '${command:AskForTDMLName}'
- tdmlConfig.description = '${command:AskForTDMLDescription}'
- tdmlConfig.path = targetResource.fsPath
+ tdmlConfig.path = targetResource.fsPath.toString()
+
+ tdmlConfig.name =
+ tdmlConfig.name ||
+ (await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getTDMLName',
+ tdmlConfig.path
+ ))
+
+ tdmlConfig.description =
+ tdmlConfig.description ||
+ (await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getTDMLDescription',
+ tdmlConfig.path
+ ))
+
+ if (!tdmlConfig.name || !tdmlConfig.description) {
+ vscode.window.showErrorMessage(
Review Comment:
I'm not sure that we want this error message here. It makes sense to have
one in the case where no test cases are found, but it doesn't make sense if the
user presses Esc. Maybe we can meet in the middle and do a toast message in the
bottom right, the same way we do for the Infoset being created?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
