michael-hoke commented on code in PR #1359:
URL: https://github.com/apache/daffodil-vscode/pull/1359#discussion_r2274673421
##########
src/adapter/activateDaffodilDebug.ts:
##########
@@ -175,17 +175,6 @@ async function createDebugRunFileConfigs(
if (tdmlAction === 'execute') {
tdmlConfig.path = targetResource.fsPath
-
- tdmlConfig.name =
- tdmlConfig.name ||
- (await vscode.commands.executeCommand(
- 'extension.dfdl-debug.getTDMLName',
- tdmlConfig.path
- ))
-
- if (!tdmlConfig.name) {
- return
- }
Review Comment:
This block is only hit when running from the command palette. I moved it
into a different location so that it would hit both the command palette and the
launch config execution paths.
The reason that this block fixed a bug we were seeing beforehand was that we
were defaulting to a tdmlConfig being {}. Because of this, the getConfig
function wasn't overwriting anything, causing us to be sending {} as the
tdmlConfig to the backend, causing no TDML file to be generated. Additionally
in this PR, the tdmlConfig defaults to being undefined, which allows the
getConfig to properly assign the default value of { "action": "generate" }.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
