stevedlawrence commented on code in PR #186:
URL: https://github.com/apache/daffodil-site/pull/186#discussion_r2283023359
##########
.github/workflows/update-docs.yml:
##########
@@ -106,13 +106,14 @@ jobs:
if: ${{ inputs.project == 'daffodil-vscode.wiki' }}
run: |
SITE_ROOT=${{ github.workspace }}/site
- DOCS_DIR=$SITE_ROOT/site/docs/vscode/$VERSION
+ DOCS_DIR=$SITE_ROOT/docs/vscode/$VERSION
Review Comment:
I think this change is incorrect? `SITE_ROOT` is the root of the
daffodil-site git repo (it's checked out under `${github.workspace}/site` in
the first `actions/checkout` action). Within the daffodils-site repo is a
`site/` directory where all the website content is stored. So there are two
`site`'s in the path to get to where files should go.
I'm not against an update that would make this more clear, it is definitely
confusing. But we could just open an issue if we want to do that some other
time--doesn't have to be part of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
