JeremyYao commented on code in PR #1363: URL: https://github.com/apache/daffodil-vscode/pull/1363#discussion_r2285484851
########## CHANGELOG.md: ########## Review Comment: You may want to consider running the MD file through Grammarly and seeing what grammatical items it catches. Running the MD file presents this <img width="1935" height="531" alt="image" src="https://github.com/user-attachments/assets/a4cb8101-432c-4419-9a54-4684976f8180"; /> ########## README.md: ########## Review Comment: Running the file through Grammary presents this: <img width="1901" height="831" alt="image" src="https://github.com/user-attachments/assets/6cf83d4d-3262-48ab-94e8-b1db59e10e5b"; /> You may want to consider running the file through Grammarly and using some of its' suggestions ########## images/asf_logo_url.svg: ########## Review Comment: CI is throwing an error due to the inclusion of the .svg file being in the readme. ########## CHANGELOG.md: ########## @@ -0,0 +1,283 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + + +<div align="center"> + +<img src="https://daffodil.apache.org/assets/themes/apache/img/apache-daffodil-logo.png"; height="85" alt="Apache Daffodil"/> Review Comment: Change this line to `` so that we use as much Markdown syntax as we can -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://daffodil.apache.org/assets/themes/apache/img/apache-daffodil-logo.png"](https://daffodil.apache.org/assets/themes/apache/img/apache-daffodil-logo.png"){kind=link}
