michael-hoke opened a new pull request, #1375: URL: https://github.com/apache/daffodil-vscode/pull/1375
Closes #1358 Closes #1344 This PR is also meant to be a trial run for a PR template - please provide any feedback in #1374 ## Description - Dynamically evaluate a command's enablement conditions for displaying it in the Daffodil Explorer Pane - Unify all commands from all sources to have (mostly) the same enablement/when conditions - Fix keywords used in enablement/when conditions to be common and succinct ## Wiki - [ ] I have determined that no wiki updates are needed for these changes - [ ] I have added documentation to the wiki for these changes I am not sure if we need user-facing wiki updates for these changes. However, documenting the below screenshot somewhere as an internal reference for when we need to add/modify commands is probably a good idea. ## Screenshots (if applicable) Here is a spreadsheet containing all 18 of our extension's commands (not including the 2 commandsView commands that were separately getting filtered out). Conditions for when they should appear are showing at the top, except for the one bolded note. I have unified all commands on all locations (command palette, editor/title, editor/title/run, commands view) to be the same (except for the one note). Please review these as well and make sure that these all make sense. <img width="1682" height="351" alt="image" src="https://github.com/user-attachments/assets/a193956f-cc0f-4c45-89f8-cee4346199d6"; /> The keywords are variables/macros that appear in the context of the contributes/commands section in the package.json. The commands view keys off of a command's enablement field, and we have to supply the value to the parser so that it can evaluate the statements. These keys are internal values that VSCode is able to fill in when looking at something like the command palette, but it does not expose a way for us to read these values in our code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
