stevedlawrence commented on code in PR #1371: URL: https://github.com/apache/daffodil-vscode/pull/1371#discussion_r2302152690
########## build/package/NOTICE: ########## @@ -2100,3 +2100,18 @@ The following NOTICE information applies to binary components distributed with t HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +- org.fusesource.jansi-<VERSION>.jar + Copyright (C) 2009-2023 the original author(s). + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. Review Comment: This doesn't actually doesn't need to be (or should be) in the NOTICE file. The guidance for license files is if a dependency is not ALv2 then it needs to be mentioned in the LICENSE file. If it is ALv2, then it should not be listed in the LICENSE file, but we need to copy its NOTICE content into our NOTICE file--if it doesn't have a NOTICE file then nothing needs to be done. Jansi does not have a NOTICE file so there's nothing that needs to be done for it to be complaint with ASF licensing requirements. However, this project maintains NONOTICE files as a way to keep track of which ALv2 dependencies don't have a NOTICE vs we just forgot to add the NOTICE information. So jansi should be listed in the NONOTICE file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org