michael-hoke commented on code in PR #1409: URL: https://github.com/apache/daffodil-vscode/pull/1409#discussion_r2337049916
########## DEVELOPMENT.md: ########## @@ -224,10 +223,6 @@ Upon opening, VSCode may prompt you to install recommended extensions. Go ahead Review Comment: It won't let me attach this to the above line, but I don't think the 'Go ahead and accept installing the recommended extensions' applies here anymore - I see that this is the README for devs, but Prettier is a different "type" of recommended extension than the other two. Instead, could we add a very short description alongside each recommended extension for when these would be needed? eg: Prettier - Code formatter needed to pass CI formatting checks for PRs Jar Viewer - DFDL schema files can be packed in jar files when passed to Daffodil. This extension allows the debugger to show these schema files while stepping through them. Highlight Matching Tag - Convenience extension to better highlight opening and closing tags in DFDL schema files ########## DEVELOPMENT.md: ########## @@ -224,10 +223,6 @@ Upon opening, VSCode may prompt you to install recommended extensions. Go ahead - [Prettier - Code formatter - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode) -#### Required VSCode Extensions - -Daffodil-VSCode depends on the following extensions - - [JAR Viewer - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=wmanth.jar-viewer) Review Comment: ```suggestion - [Highlight Matching Tag - Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=vincaslt.highlight-matching-tag) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
