stevedlawrence commented on code in PR #189:
URL: https://github.com/apache/daffodil-site/pull/189#discussion_r2345134845


##########
site/_layouts/release.html:
##########
@@ -3,6 +3,8 @@
 permalink: /release/release-notes-:title
 ---
 
+{% assign major_version = page.title | split: '.' | first | plus: 0 %}

Review Comment:
   Yeah, Jekyll uses the [Liquid](https://shopify.github.io/liquid/) template 
language, and it doesn't have a way to explicitly convert a string to a number. 
You just have to rely on type coercion, which is what `plus: 0` (or 
alternatively `times: 1`) does--seems to the be the standard way to do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to