michael-hoke commented on code in PR #1414:
URL: https://github.com/apache/daffodil-vscode/pull/1414#discussion_r2356096595
##########
src/dataEditor/dataEditorClient.ts:
##########
@@ -119,7 +120,11 @@ export function activate(ctx: vscode.ExtensionContext):
void {
DATA_EDITOR_COMMAND,
async (fileToEdit: string = '') => {
let configVars = editor_config.extractConfigurationVariables()
- return await createDataEditorWebviewPanel(ctx, configVars, fileToEdit)
+ return await createDataEditorWebviewPanel(
+ ctx,
+ configVars,
+ vscode.debug.activeDebugSession ? getCurrentConfig().data :
fileToEdit
Review Comment:
yes and no. Prior to this PR, config.data isn't set on a debugging session
until after it has completed. This PR sets it before launching the debugging
session - this was the cause of the data editor prompting the user for the
file. I think there might be cases where the data editor picks up the file
properly, but the main case was when the `openDataEditor` flag was set to
`true` in a launch config.
I think I want to make a separate issue for the activeDebugSession. #1375
has an instance of it as well that probably should be changed, and the
`toggleFormatting` command probably should be tweaked to use it as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
