stricklandrbls commented on PR #1384:
URL: https://github.com/apache/daffodil-vscode/pull/1384#issuecomment-3300133441

   @rthomas320 - I think there was an issue with how the old version of the 
`Create TDML File` was working:
   ```ts
     file = await vscode.window
       .showSaveDialog({
         saveLabel: label,
         title: title,
         filters: {
           TDML: ['tdml'],
         },
       })
       .then((fileUri) => {
         if (fileUri) {
           return normalizePath(fileUri.fsPath)
         }
   
         return ''
       })
   ```
   Previously, this block was already inside an `async` function then calling 
`await` on another asynchronous function while also providing a `.then` clause 
_and_ a return value. I updated this to `await` then moved the clause out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to