shanedell commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2411496887
##########
src/daffodilDebugger/utils.ts:
##########
@@ -59,33 +66,58 @@ export async function runDebugger(
dfdlDebugger: DFDLDebugger,
createTerminal: boolean = false
): Promise<vscode.Terminal> {
- const dfdlVersion = daffodilVersion(filePath)
+ if (!['2.12', '2.13', '3'].includes(dfdlDebugger.version)) {
+ vscode.window.showErrorMessage(
+ `DFDL Debugger Version ${dfdlDebugger.version} not supported. Supported
versions are 2.12, 2.13 and 3.`
Review Comment:
@stevedlawrence would it be better to make it so we are doing `!['3.10.0',
'3.11.0', '4.0.0'].includes(dfdlDebugger.version)`? `dfdlDebugger.version` is a
new launch config variable that can be used, I initially made it be set to the
scala version but looking back over it maybe it should use the version of
Daffodil being used and then based on that we know which version of the
debugger/scala to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
