JeremyYao commented on code in PR #1427:
URL: https://github.com/apache/daffodil-vscode/pull/1427#discussion_r2376449101
##########
src/dataEditor/dataEditorClient.ts:
##########
@@ -101,6 +100,7 @@ export const APP_DATA_PATH: string = XDGAppPaths({ name:
'omega_edit' }).data()
const HEARTBEAT_INTERVAL_MS: number = 1000 // 1 second (1000 ms)
const MAX_LOG_FILES: number = 5 // Maximum number of log files to keep TODO:
make this configurable
+const OPEN_EDITORS = new Map<string, vscode.WebviewPanel>()
Review Comment:
Functionality works, so my +1 will still hold, but something to consider
here is potentially changing this to a set as it appears like you're only
checking the keys from the map.
Additionally, the const being here may be confusing as the map is being
mutated as you're adding keys. Consider changing the casing of the variable
name as well as making the variable global. See if this helps:
https://chatgpt.com/share/68d42453-5314-800b-b6e3-a406f30e105d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
