stevedlawrence commented on code in PR #1452:
URL: https://github.com/apache/daffodil-vscode/pull/1452#discussion_r2417084579
##########
package.json:
##########
@@ -760,6 +774,8 @@
}
},
"dfdlDebugger": {
+ "version": "2.13",
Review Comment:
One of the comments above suggests this wants to be a daffodil version, and
not a scala version. Should this be 3.11.0?
##########
build.sbt:
##########
@@ -150,11 +112,11 @@ lazy val xjcSettings =
// classes
lazy val xjcSourceDir = crossTarget.value / "xjc"
- // Get the daffodil-lib jar from the dependencies, this is the only jar
we need to extract
+ // Get the daffodil-lib or daffodil-core jar from the dependencies, this
is the only jar we need to extract
// files from
val daffodilLibJar = managedJars(Test, Set[String]("jar"), update.value)
Review Comment:
We might want to rename `daffodiLibJar` since this isn't necessarily the
daffodil-lib jar anymore. Maybe something like `daffodilJarWithTdmlXsd` to make
it clear we just need this for the TDML XSD file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
