shanedell opened a new pull request, #1453:
URL: https://github.com/apache/daffodil-vscode/pull/1453

   ## Description
   
   Remove workflow_dispatch from main CI file as it doesn't work as expected.
   
   ### Justification
   
   The reason for adding this before was to make it so we could manually 
trigger the CI workflow for a PR. However, even though this will run the CI for 
the changes, it doesn't update the status of the PR checks. So, even when these 
are triggered you would have to dig through the CI job to know its running for 
a PR and not something else. For this reason I think we should just remove it 
as I don't think its helpful and add a lot non-necessary complexity to the CI 
file.
   
   If you take a look at 
https://github.com/apache/daffodil-vscode/actions/runs/18291401974. I manually 
triggered CI workflow on the branch `update/munit-1.2.0` for PR 
https://github.com/apache/daffodil-vscode/pull/1445. However, when looking at 
https://github.com/apache/daffodil-vscode/pull/1445/checks nothing shows up 
even though the CI succesfully ran on the branch and PR.
   
   I also updated the concurrency group to be a little more detailed and cancel 
in progress. This was in effort to more closely match what is done at 
https://github.com/apache/daffodil/blob/main/.github/workflows/main.yml and  
https://github.com/apache/daffodil-sbt/blob/main/.github/workflows/main.yml
   
   ## Wiki
   
   - [x] I have determined that no documentation updates are needed for these 
changes
   - [ ] I have added following documentation for these changes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to