rthomas320 commented on PR #1450: URL: https://github.com/apache/daffodil-vscode/pull/1450#issuecomment-3376284267
> > Testing on Windows 10. The data editor doesn't close after debug completes. > > These changes should not have affected the editor closing in any way. Are we sure this is due to these changes? Is this happening on main? > > I see that you recently had reviewed the changes that involved the vscode debug session termination callbacks. This would most definitely affect the data editor closing. > > Did you git clean prior to testing this? . I did perform git clean -fdx prior to debugging the extension. I pulled in the latest code from main and the problem is now occurring in main. It is also occurring in PR #1429 Updated DataEditorClient disposal ordering. <img width="919" height="621" alt="image" src="https://github.com/user-attachments/assets/549f3bab-3e57-40f5-b93e-71aefaa7380e"; /> The problem seems to have been introduce in by PR #1427 DFDL-1369. I reverted the code to the prior commit 2ae578f814fc7f3fb15d5b6a2897490e46dd8f86 (PR #1430 add misc development information) and the problem didn't exist in that code.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
