scholarsmate commented on code in PR #1426:
URL: https://github.com/apache/daffodil-vscode/pull/1426#discussion_r2452973571
##########
src/tests/suite/language/items.test.ts:
##########
@@ -73,12 +73,16 @@ suite('Items Test Suite', () => {
const expectedAttributeItems = [
'name',
'ref',
+ 'default',
+ 'fixed',
'minOccurs',
'maxOccurs',
Review Comment:
Should these remain?
##########
src/language/providers/attributeCompletion.ts:
##########
@@ -393,32 +393,95 @@ function checkNearestOpenItem(
return getCompletionItems(
[
'name',
+ 'maxOccurs',
+ 'minOccurs',
+ 'nillable',
'ref',
'type',
- 'minOccurs',
- 'maxOccurs',
Review Comment:
Should these have been removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
