olabusayoT commented on code in PR #20:
URL: 
https://github.com/apache/daffodil-infrastructure/pull/20#discussion_r2499962839


##########
actions/release-candidate/action.yml:
##########
@@ -36,20 +36,20 @@ inputs:
     required: true
   svn_username:
     description: Username for publishing release artifacts to SVN dev/dist
-    required: true
+    required: false
   svn_password:
     description: Password for publishing release artifacts to SVN dev/dist
-    required: true
+    required: false
   nexus_username:
     description: Username for publishing release artifacts to Nexus
-    required: true
+    required: false
   nexus_password:
     description: Password for publishing release artifacts to Nexus
-    required: true
+    required: false
   publish:
     description: Enable/disabling publish artifacts. Must be explcitly set to 
true to enable publishing. Maybe ignored depending on other factors.
     required: false
-    default: false
+    default: "false"

Review Comment:
   Correct, the schema for default says it's a string so intellij was giving a 
warning about it
   
   ```json
   "default": {
     "$comment": 
"https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddefault";,
     "description": "A string representing the default value. The default value 
is used when an input parameter isn't specified in a workflow file.",
     "type": "string"
   }
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to