stricklandrbls commented on code in PR #1532:
URL: https://github.com/apache/daffodil-vscode/pull/1532#discussion_r2543435383
##########
src/daffodilDebugger/utils.ts:
##########
@@ -121,6 +121,15 @@ export async function runDebugger(
// Download the daffodil CLI jars if needed
const daffodilPath = await checkIfDaffodilJarsNeeded(dfdlVersion)
+ /**
+ * If 'error' returned from checkIfDaffodilJarsNeeded then there was an
error hit somewhere inside of that
+ * function, most likely downloading/extracting the JARS. Whenever any error
is hit from that function, the
+ * extension shouldn't run the debugger.
+ */
+ if (daffodilPath == 'error') {
Review Comment:
Make this conditional an explicit type & value check w/ `===`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
