stevedlawrence commented on code in PR #209:
URL: https://github.com/apache/daffodil-site/pull/209#discussion_r2651092418
##########
site/_includes/themes/apache/_navigation.html:
##########
@@ -4,11 +4,13 @@
<nav role="navigation">
<ul class="nav navbar-nav navbar-right">
<li><a href="/releases">Releases</a></li>
- <li id="extensions">
- <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Extensions<b class="caret"></b></a>
+ <li id="Projects">
+ <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Projects<b class="caret"></b></a>
<ul class="dropdown-menu dropdown-left">
- <li><a href="/vscode">VS Code</a></li>
- <li><a href="/sbt">SBT</a></li>
+ <li><a href="/releases">Main Daffodil Library and CLI</a></li>
Review Comment:
Thoughts on dropping "Main"? It feels like "Daffodil Library and CLI" is
sufficiently descriptive.
Also, should we update the /releases page so the title matches this? Right
now the title is just "Releases", which doesn't really make it clear it's the
releases for the Library and CLI.
##########
site/_includes/themes/apache/_navigation.html:
##########
@@ -4,11 +4,13 @@
<nav role="navigation">
<ul class="nav navbar-nav navbar-right">
<li><a href="/releases">Releases</a></li>
- <li id="extensions">
- <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Extensions<b class="caret"></b></a>
+ <li id="Projects">
Review Comment:
This probably wants to be all lowercase to match the other ids. I'm not sure
if it actually matters but it does make things more consistent.
##########
site/_includes/themes/apache/_navigation.html:
##########
@@ -4,11 +4,13 @@
<nav role="navigation">
<ul class="nav navbar-nav navbar-right">
<li><a href="/releases">Releases</a></li>
- <li id="extensions">
- <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Extensions<b class="caret"></b></a>
+ <li id="Projects">
+ <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Projects<b class="caret"></b></a>
<ul class="dropdown-menu dropdown-left">
- <li><a href="/vscode">VS Code</a></li>
- <li><a href="/sbt">SBT</a></li>
+ <li><a href="/releases">Main Daffodil Library and CLI</a></li>
+ <li><a href="/vscode">VS Code IDE for DFDL</a></li>
Review Comment:
Thoughts on "VS Code Extension for DFDL"?
@shanedell , do you have any thoughts on what what this wants to be called.
##########
site/_includes/themes/apache/_navigation.html:
##########
@@ -4,11 +4,13 @@
<nav role="navigation">
<ul class="nav navbar-nav navbar-right">
<li><a href="/releases">Releases</a></li>
- <li id="extensions">
- <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Extensions<b class="caret"></b></a>
+ <li id="Projects">
+ <a href="#" data-toggle="dropdown"
class="dropdown-toggle">Projects<b class="caret"></b></a>
<ul class="dropdown-menu dropdown-left">
- <li><a href="/vscode">VS Code</a></li>
- <li><a href="/sbt">SBT</a></li>
+ <li><a href="/releases">Main Daffodil Library and CLI</a></li>
+ <li><a href="/vscode">VS Code IDE for DFDL</a></li>
+ <li><a href="/sbt">SBT Build Tool for DFDL Schema
Projects</a></li>
Review Comment:
SBT Build Tool is kind of repetitive since SBT stands for "Simple Build
Tool". We may also want to indicate it's a plugin? Maybe something like "SBT
(Simple Build Tool) Plugin for DFDL Projects"
Also, do we want to be consistent about "DFDL" vs "DFDL Projects" vs "DFDL
Schema Project"? Feels like they all kindof mean the same thing but each links
all use slightly different wording. Or maybe they aren't needed at all and it's
implied?
##########
site/index.md:
##########
@@ -24,7 +24,9 @@ limitations under the License.
The [Data Format Description Language
(DFDL)](https://www.ogf.org/ogf/doku.php/standards/dfdl/dfdl)
-is a specification, developed by the [Open Grid Forum](https://www.ogf.org/),
+is a specification, developed by the [Open Grid Forum](https://www.ogf.org/),
and now is also
Review Comment:
Thoughts on dropping "now" since that that kindof indicates it happened
recently, but in the future that won't be so recent and might not age very
well. Maybe something like:
> ... is a specification, developed by the Open Grid Form and also published
as ISO/IEC 23415:2004, capable of ...
##########
site/_includes/themes/apache/_navigation.html:
##########
@@ -4,11 +4,13 @@
<nav role="navigation">
<ul class="nav navbar-nav navbar-right">
<li><a href="/releases">Releases</a></li>
Review Comment:
Agreed, I think it makes sense to remove the `Releases` nav dropdown.
##########
site/g8template.md:
##########
Review Comment:
Thoughts on just naming this "template" or something? The page title doesn't
mention g8 so I wonder if we g8 is more of an implementation detail that
doesn't necesarily want to be in the URL? It also makes for an easier to use
URL for sharing or remembering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
