ItsZetty opened a new pull request, #1575: URL: https://github.com/apache/daffodil-vscode/pull/1575
Closes #1573 ## Description This PR adds comprehensive documentation for the pull request approval and merge process to DEVELOPMENT.md, addressing issue #1573. ### Context The Apache Daffodil project follows a specific contribution workflow that requires PMC/committer approvals before merging PRs. This information was previously only available in the external Apache Daffodil Code Contributor Workflow wiki, making it difficult for new contributors to understand the approval requirements. ### Changes - Added new section "Pull Request Approval and Merge Process" to DEVELOPMENT.md - Documented requirement for two +1 votes (green approvals) from PMC members or committers - Included detailed review cycle workflow (Submit → Feedback → Address → Approval → Merge) - Documented merging process requiring "Rebase and merge" method - Added post-merge actions (closing issues, adding commit hash) - Included guidelines for contributors before starting work (assign issues, communicate) - Referenced Apache Daffodil Code Contributor Workflow for additional details - Updated Table of Contents with new sections ## Wiki - [x] I have determined that no documentation updates are needed for these changes The changes are self-contained within DEVELOPMENT.md, which serves as the primary developer documentation. ## Review Instructions including Screenshots The new section appears after the "General Workflow" section and before "Opening the Repository in VSCode" in DEVELOPMENT.md (lines 213-260). **Key sections added:** 1. **Approval Requirements** - Explains the two-approval requirement 2. **Review Cycle** - 5-step process for PR review and approval 3. **Merging Process** - ASF committer requirements and "Rebase and merge" method 4. **Post-Merge Actions** - Issue management and traceability 5. **Before Starting Work** - Best practices for contributors 6. **Additional Resources** - Link to Apache Daffodil Code Contributor Workflow The documentation follows the existing DEVELOPMENT.md format and writing style, using clear headings, bold text for important requirements, and bullet points for step-by-step instructions. ### Confirmation Testing This is a documentation-only change. No code functionality is modified. - Verified markdown formatting renders correctly - Confirmed all internal anchor links in Table of Contents work properly - Validated external link to Apache Daffodil Code Contributor Workflow is accessible ### Regression Testing No regression testing required as this PR only adds documentation and does not modify any code, build scripts, or configuration files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
