olabusayoT commented on code in PR #1610:
URL: https://github.com/apache/daffodil/pull/1610#discussion_r2683652097
##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/oolag/OOLAG.scala:
##########
@@ -487,7 +487,7 @@ object OOLAG {
* that have been created and activated at the time this is called.
*/
def isError: Boolean = isErrorOnce
- private lazy val isErrorOnce: Boolean = {
+ private def isErrorOnce: Boolean = {
Review Comment:
I changed it to a def since we do need it ro recalculate each time isError
is called. With the lazy eval, if it is false once, it doesn't recalculate and
just always returns false. These lazy evals were causing the new test to fail,
as it gets called during the compileFile and set to false, then when onPath is
called and the sset.error sets it, and isError is called again, it still
returns false.
With the change suggested below to move the SDE somewhere else, I think this
change will go away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
