stricklandrbls commented on code in PR #1564:
URL: https://github.com/apache/daffodil-vscode/pull/1564#discussion_r2692736402
##########
src/svelte/src/components/DataMetrics/DataMetrics.svelte:
##########
@@ -157,20 +157,27 @@ limitations under the License.
})
}
+ let lastProfileTarget: 'editor' | 'disk' | null = null
Review Comment:
Given that this variable instance type is used in multiple places it should
be extracted to a concrete type definition:
```ts
type ProfileTarget = 'editor' | 'disk'
```
Then change the appropriate variable's types:
```ts
let lastProfileTarget: ProfileTarget | undefined = undefined
let lastRequestedTarget: ProfileTarget = 'editor'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
