stevedlawrence commented on code in PR #213:
URL: https://github.com/apache/daffodil-site/pull/213#discussion_r2695547126
##########
.github/workflows/update-docs.yml:
##########
@@ -75,7 +75,17 @@ jobs:
- name: Install Dependencies
run: |
- sudo apt-get install -y libmxml-dev pandoc
+ sudo apt-get update
+ sudo apt-get install -y libmxml-dev
+
+ - name: Install Pandoc 3.8.3
+ run: |
+ PANDOC_VERSION=3.8.3
+ curl -L \
+
https://github.com/jgm/pandoc/releases/download/${PANDOC_VERSION}/pandoc-${PANDOC_VERSION}-linux-amd64.tar.gz
\
+ | tar xz
+ sudo mv pandoc-${PANDOC_VERSION}/bin/pandoc /usr/local/bin/pandoc
+ pandoc --version
Review Comment:
Would it work to download the .deb (same link just with .deb instead of
.tar.gz) and install that? Might be just a bit simpler than having to extract a
tar and move files.
##########
.github/workflows/update-docs.yml:
##########
@@ -31,7 +31,7 @@ on:
- daffodil-vscode.wiki
required: true
version:
- description: Version (e.g. v1.0.0-rc1)
+ description: Version (Daffodil ex. v4.0.0-rc1, Daffodil-vscode ex.
1.5.0)
Review Comment:
You should be able use the same `vX.Y.Z-rcx` for both daffodil and vscode.
The "Extract Version" step expects the `version` input to include the `v`
and `rcX` and strips them off.
I think this would be preferred for consistency, and also if vscode ever
moves docs into the main repo (I think there was some discussion to do this?),
then we can change the checkout action to just be
```
ref: $inputs.project
```
so that it checks out the tag instead of the wiki master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
