stevedlawrence commented on code in PR #1602:
URL: https://github.com/apache/daffodil-vscode/pull/1602#discussion_r2769420273
##########
.github/workflows/CI.yml:
##########
@@ -107,6 +110,7 @@ jobs:
build-test-package:
name: "Build, Test, and Package (OS: ${{ matrix.os }}, Node: ${{
matrix.node }}, Java: ${{ matrix.java_version }}, VS Code: ${{ matrix.vscode
}})"
strategy:
+ max-parallel: 15
Review Comment:
Sure, daffodil only has one job for macOS so cutting back some of the OS
matrices seems reasonable to me. Especially since typescript and Java are
mostly OS agnostic.
The main issue we frequently run into with OS differences is related to
paths (e.g. slashes, spaces, newlines). And those are usually Java/typescript
version agnostic. So also long as you have at least one job for each OS, one
job for each Java version, typescript version, etc. you probably can get away
with having a fairly sparse matrix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
